Remove logging of priority in Geolocation.kt #3002
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed logging of priority level in location request.
|
Thanks for the PR :) This log line was indeed not supposed to make it into production, thanks for catching that.
No worries mate, no issue needed for relatively simple fixes. |
Package Changes Through c1c95efThere are 2 changes which include updater with minor, updater-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
FabianLars
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr fixes this
when polling location it was rather annoying.
also there's a bug here: you have to poll location manually if you want <10s location updates because there seems to be hardcoded location update rates in https://github.com/tauri-apps/plugins-workspace/blob/v2/plugins/geolocation/android/src/main/java/Geolocation.kt#L96-L100
please forgive me for not abiding your contribution guidelines and formatting for the title, its not that i don't respect you guys its just that i dont have enough stimulants in me to put the effort into opening an issue